BREAKING: Update to react-dom 18 client changes#1186
Closed
ynagorny wants to merge 1 commit into
Closed
Conversation
Collaborator
|
This seems to be a breaking change for those that don't upgrade to React 18. Please confirm. Do you want to propose a solution that works with React 16+17 and React 18? |
justin808
changed the title
|
Functions like I've created a PR (#1194) which uses the correct core/client APIs and attempts to provide backwards compatibility for React 16/17. Can someone test? |
Collaborator
|
Closed in favor of #1194. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to import react-dom/client package instead of react-dom as described in:
https://reactjs.org/docs/react-dom.html
This takes care of this react 18 warning:
You are importing createRoot from "react-dom" which is not supported. You should instead import it from "react-dom/client".